Skip to content

Conversation

@eyalkoren
Copy link
Contributor

I added all in TRACE level. We ask for DEBUG logs frequently, we don't want a per-request/http-exit logging.
If you have any ideas for additional info we may be interested at - let me know.

@ghost
Copy link

ghost commented Oct 5, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #1425 updated]

  • Start Time: 2020-10-05T13:51:46.988+0000

  • Duration: 49 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 1564
Skipped 12
Total 1576

Copy link
Member

@SylvainJuge SylvainJuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

[minor] do we really require the isTraceEnabled() call first with slf4j for those cases ?

@eyalkoren
Copy link
Contributor Author

eyalkoren commented Oct 5, 2020

do we really require the isTraceEnabled() call first with slf4j for those cases ?

I used it where a toString may be invoked otherwise, to spare the related (potentially multiple) allocations. Didn't look in all implementations though, possibly it is never called if the logging level does not qualify...

Update: looked it up - the check is not required for the toString resolve (as expected), but still worth the check when using with multiple message format variables (varargs API), to avoid the Object array allocation.

@eyalkoren eyalkoren merged commit f8420e6 into elastic:master Oct 6, 2020
@eyalkoren eyalkoren deleted the add-trace-log-info-to-http-spans branch October 6, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants