Implement sampling #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(closes #3) Signed-off-by: Felix Barnsteiner <felix.barnsteiner@elastic.co>
alvarolobato
approved these changes
Mar 21, 2018
Contributor
There was a problem hiding this comment.
Looks good to me. I was a bit confused at first by the name of the method isSampledbut after reading the rest of the code I get it. For me it would be maybe more intuitive to say a transaction is a sample not sampled, but I'm not english native....
|
|
||
| import co.elastic.apm.impl.transaction.TransactionId; | ||
|
|
||
| public class ConstantSampler implements Sampler { |
Contributor
There was a problem hiding this comment.
Maybe some java doc saying what this is?
|
|
||
| import co.elastic.apm.impl.transaction.TransactionId; | ||
|
|
||
| public class ProbabilitySampler implements Sampler { |
Contributor
There was a problem hiding this comment.
Maybe some java doc saying what this is?
| import co.elastic.apm.impl.transaction.TransactionId; | ||
|
|
||
| /** | ||
| * A sampler is responsible for determining whether a {@link co.elastic.apm.api.Transaction} should be sampled. |
Contributor
|
BTW CI is failing, I guess it is they Keystore problem you are trying to fix in the other PR. |
Member
Author
|
@Qard does |
|
No, seems reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes #3)
Signed-off-by: Felix Barnsteiner felix.barnsteiner@elastic.co