Skip to content

Conversation

@SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Jul 29, 2021

What does this PR do?

Work-around for compatibility issue with Jackson JSON serialization on Java 15 and 16.
Also, rollback jackson version to 2.12.x branch to ensure Java7 compatibility (2.13.x is built with Java 8) (see doc)

@ghost
Copy link

ghost commented Jul 29, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-20T09:39:36.087+0000

  • Duration: 56 min 46 sec

  • Commit: 7771dd2

Test stats 🧪

Test Results
Failed 0
Passed 2379
Skipped 19
Total 2398

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2379
Skipped 19
Total 2398

@SylvainJuge
Copy link
Member Author

FYI I realized that changing jackson version is not as trivial as it sounds as we have it in many levels of maven dependencies.
For example, mixing spring-boot versions with the one we already have through core module tends to conflict and create weird classloading issues because jackson dependencies structure changed (thus inclusions/exclusions do not work as expected).

Thus we can consider this still WIP until proper review is required.

@SylvainJuge SylvainJuge changed the title Work-around for Jackson on Java15+ Work-around for Jackson & instrumentation issues on Java15+ Aug 19, 2021
@SylvainJuge
Copy link
Member Author

Update: should be ready to review/merge, even if the build still does not run without error on Jdk 14-16.

@SylvainJuge SylvainJuge merged commit 849b1f5 into master Aug 20, 2021
@SylvainJuge SylvainJuge deleted the fix-java16-jackson branch August 20, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants