Skip to content

Conversation

@eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Dec 8, 2021

Implements #2092 for Scala concurrency plugin

@ghost
Copy link

ghost commented Dec 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-08T14:04:50.181+0000

  • Duration: 66 min 27 sec

  • Commit: 4cca40d

Test stats 🧪

Test Results
Failed 0
Passed 2627
Skipped 21
Total 2648

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run compatibility tests : Run the JDK Compatibility test.

  • run integration tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@jackshirazi jackshirazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice simplification! Maybe worth raising an issue for adding span lifecycle tests in scala?

@eyalkoren
Copy link
Contributor Author

Maybe worth raising an issue for adding span lifecycle tests in scala?

Good idea. We can first review and see what's missing (e.g. trying to propagate and activate a span that is already ended asynchronously). But assuming that this specific PR is not affecting that, I'll merge and keep that separately.

@eyalkoren eyalkoren merged commit c1898f3 into elastic:master Dec 8, 2021
@eyalkoren eyalkoren deleted the switch-to-SpanConcurrentHashMap-Scala branch December 8, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants