Skip to content

Conversation

@eyalkoren
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Dec 21, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-21T08:25:37.181+0000

  • Duration: 70 min 28 sec

  • Commit: 414c006

Test stats 🧪

Test Results
Failed 0
Passed 2639
Skipped 21
Total 2660

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run compatibility tests : Run the JDK Compatibility test.

  • run integration tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@eyalkoren eyalkoren requested a review from v1v December 21, 2021 09:53
@v1v
Copy link
Member

v1v commented Dec 21, 2021

Thanks Eyal, I understand now the whole problem! Then I guess the <= should be the way to go as you said

@tobiasstadler
Copy link
Contributor

Maybe the problem is that ignore does not check against the version in the pom but the version in "Maven Central"? So an update from < 1.9.16 to version 1.9.16 would be ignored, but not an update from 1.9.16 to something > 1.9.16?

@eyalkoren
Copy link
Contributor Author

@eyalkoren eyalkoren merged commit 2fa7f8b into master Dec 21, 2021
@eyalkoren eyalkoren deleted the bytebuddy-upgrade branch December 21, 2021 11:16
@tobiasstadler
Copy link
Contributor

@eyalkoren yes, I also read that. But for me it is not really clear what the ignored version refers to. https://github.community/t/configure-dependabot-to-only-create-prs-for-minor-or-patch-updates/117656 suggests it is the new version not the version in the pom.

@tobiasstadler
Copy link
Contributor

Maybe

 - package-ecosystem: "maven"
    directory: "/"
   ....
-  package-ecosystem: "maven"
    directory: "/integration-tests/runtime-attach/runtime-attach-app/"
    ...
    ignore:
      - dependency-name: "net.bytebuddy:byte-buddy-agent"

does work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants