Skip to content

cgroup max memory discovery analysis #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2022
Merged

cgroup max memory discovery analysis #2746

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39c8d99
cgroup max memory discovery analysis
eyalkoren Aug 18, 2022
2d354a0
Merge remote-tracking branch 'upstream/main' into cgroup-max-memory
eyalkoren Sep 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apm-agent-core/src/main/java/co/elastic/apm/agent/metrics/builtin/CGroupMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ private CgroupFiles createCgroup1Files(File memoryMountPath) throws IOException
private File getMaxMemoryFile(File maxMemoryFile, String cgroupUnlimitedConstant) throws IOException {
try(BufferedReader maxFileReader = new BufferedReader(new FileReader(maxMemoryFile))) {
String memMaxLine = maxFileReader.readLine();
logger.debug("max cgroup memory read from {} is: {}", maxMemoryFile.getAbsolutePath(), memMaxLine);
if (cgroupUnlimitedConstant.equalsIgnoreCase(memMaxLine)) {
// Make sure we don't send the max metric when cgroup is not bound to a memory limit
maxMemoryFile = null;
Expand Down