Skip to content

Conversation

@JonasKunz
Copy link
Contributor

What does this PR do?

The agent does not sent the activation method when a APM server older than 8.7.1 is detected.
This caused some flakyness in the AgentActivationIT: If the health-check request finished before the metadata is generated, the agent assumed a pre-6.0 apm server and therefore did not send the activation method.
If the apm-server version is not known (the health-check request did not finish yet), the activation method is sent.

@ghost
Copy link

ghost commented Apr 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-04-06T09:01:36.896+0000

  • Duration: 14 min 5 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@JonasKunz JonasKunz enabled auto-merge (squash) April 6, 2023 09:26
@JonasKunz JonasKunz merged commit e6dcd04 into elastic:main Apr 6, 2023
@JonasKunz JonasKunz deleted the activation_it_fix branch April 6, 2023 11:06
@SylvainJuge SylvainJuge mentioned this pull request Apr 12, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants