Skip to content

Conversation

@JonasKunz
Copy link
Contributor

What does this PR do?

  • Enables generation of the sources-jar for the tracer project (which we publish on maven central)
  • Force the generation of a javadoc-jar for the elastic-apm-agent / elastic-apm-agent-java8 projects.
    • Javadoc was not generated because the projects contained no code anymore
    • To workaround this, a package-info.java and a dummy class were added to both projects

/**
* This project contains the Java 8 build of the elastic apm java agent.
*/
package apm;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] why not use a more "traditional" package like co.elastic.apm.java8 so it does not conflicts with the other JavadocPlaceHolder.java and still fits a bit the other packages even if we don't really publish it ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to go with co.elastic.apm.premain.java7/java8 to be a subpackage of the other non-shaded premain classes.

@ghost
Copy link

ghost commented Apr 11, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-04-11T12:51:29.359+0000

  • Duration: 14 min 35 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge enabled auto-merge (squash) April 11, 2023 13:03
@SylvainJuge SylvainJuge merged commit bb5def3 into elastic:main Apr 11, 2023
@SylvainJuge SylvainJuge mentioned this pull request Apr 12, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants