Fix empty context activation behaviour #3227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKunz
changed the title
jackshirazi
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #3004 .
Fixes a small leftover from #3206 which I didn't want to include there as the PR was already big enough and partly reviewed
This PR changes what happens if you activate an empty context. Prior to this PR, activating an empty context was simply a NoOp, which means that the active span / baggage was left unchanged.
This has now been changed to be more consistent: If an empty context is activated, the span and baggage will actually be empty.
This is something which usually does not occur in production code, as we do not propagate empty contexts. It however can be pretty useful for tests and is done for overall consistency.
Checklist
I have updated CHANGELOG.asciidoc