Add error reporting API to tracer-api. #3273
Conversation
github-actions
bot
added
agent-java
community
|
👋 @raphw Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
|
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
|
Force pushed with new hash to trigger new build which failed due to low memory on testcontainers. |
# Conflicts: # apm-agent-core/src/main/java/co/elastic/apm/agent/impl/ElasticApmTracer.java # apm-agent-plugins/apm-logging-plugin/apm-logging-plugin-common/src/main/java/co/elastic/apm/agent/loginstr/error/LoggerErrorHelper.java # apm-agent-tracer/src/main/java/co/elastic/apm/agent/tracer/GlobalTracer.java # apm-agent-tracer/src/main/java/co/elastic/apm/agent/tracer/NoopTracer.java # apm-agent-tracer/src/main/java/co/elastic/apm/agent/tracer/Tracer.java
JonasKunz
left a comment
JonasKunz
left a comment
There was a problem hiding this comment.
LGTM, I've done the rebase and just added two missing @Override annotations.
|
run elasticsearch-ci/docs |
* Add error reporting API to tracer-api. * Added missing @OverRide annotations --------- Co-authored-by: Jonas Kunz <jonas.kunz@elastic.co>
3 participants
This change adds an representation of
ErrorCaptureto the tracer API to avoid a dependency on the core module. To reduce complexity, errors are always reported on the current span. No plugin derives from this practice what makes this sensible.