-
Notifications
You must be signed in to change notification settings - Fork 327
build: bump org.springframework.boot:spring-boot-dependencies from 2.7.16 to 3.4.1 #3926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JonasKunz
merged 9 commits into
main
from
dependabot/maven/org.springframework.boot-spring-boot-dependencies-3.4.1
Jan 21, 2025
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d60ef72
build: bump org.springframework.boot:spring-boot-dependencies
dependabot[bot] 32b49a6
rollback
jackshirazi e5a3b9e
rollback
jackshirazi df3c1eb
rollback
jackshirazi 3300392
relax a bit assertion to make test pass
SylvainJuge f2966d4
Renamed test to verify invalid line numbers provided by CI logs
JonasKunz d125b97
Merge remote-tracking branch 'elastic/main' into dependabot/maven/org…
JonasKunz a58df2a
Revert "Renamed test to verify invalid line numbers provided by CI logs"
JonasKunz b589b7f
Remove hardcoded reference to spring version from tests
JonasKunz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
18 changes: 18 additions & 0 deletions
18
...d-metrics-sdk/src/test/java/co/elastic/apm/agent/embeddedotel/EmbeddedSdkManagerTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,6 +38,7 @@ | |
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.params.ParameterizedTest; | ||
| import org.junit.jupiter.params.provider.CsvSource; | ||
| import org.springframework.core.SpringVersion; | ||
| import org.springframework.http.codec.ServerSentEvent; | ||
| import org.springframework.web.reactive.function.client.WebClientResponseException; | ||
| import reactor.core.publisher.Hooks; | ||
|
|
@@ -58,7 +59,6 @@ public abstract class AbstractServerInstrumentationTest extends AbstractInstrume | |
| private static final String BASIC_AUTH_HEADER_VALUE = "Basic ZWxhc3RpYzpjaGFuZ2VtZQ=="; | ||
|
|
||
| protected static WebFluxApplication.App app; | ||
| protected String expectedFrameworkVersion = "5.3.30"; | ||
| protected GreetingWebClient client; | ||
|
|
||
| @BeforeAll | ||
|
|
@@ -134,7 +134,7 @@ private void hello(boolean expectHeaders) { | |
|
|
||
| assertThat(headersCount) | ||
| .describedAs("unexpected headers count") | ||
| .isEqualTo(6); | ||
| .isGreaterThanOrEqualTo(6); | ||
|
|
||
| assertThat(headers.getFirst("random-value")) | ||
| .describedAs("non-standard request headers should be captured") | ||
|
|
@@ -452,11 +452,7 @@ protected ErrorCaptureImpl getFirstError() { | |
| return reporter.getFirstError(200); | ||
| } | ||
|
|
||
| TransactionImpl checkTransaction(TransactionImpl transaction, String expectedName, String expectedMethod, int expectedStatus) { | ||
| return checkTransaction(transaction, expectedName, expectedMethod, expectedStatus, expectedFrameworkVersion); | ||
| } | ||
|
|
||
| static TransactionImpl checkTransaction(TransactionImpl transaction, String expectedName, String expectedMethod, int expectedStatus, String expectedFrameworkVersion) { | ||
| static TransactionImpl checkTransaction(TransactionImpl transaction, String expectedName, String expectedMethod, int expectedStatus) { | ||
| assertThat(transaction.getType()).isEqualTo("request"); | ||
| assertThat(transaction.getNameAsString()).isEqualTo(expectedName); | ||
|
|
||
|
|
@@ -473,7 +469,8 @@ static TransactionImpl checkTransaction(TransactionImpl transaction, String expe | |
| .isEqualTo("Spring Webflux"); | ||
|
|
||
| assertThat(transaction.getFrameworkVersion()) | ||
| .isEqualTo(expectedFrameworkVersion); | ||
| .isNotBlank() | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #3936 added hard-coded versions to the tests, which would bite us on every version bump. With this change we still check for the version, but use spring itself to get the expected value. |
||
| .isEqualTo(SpringVersion.getVersion()); | ||
|
|
||
| return transaction; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[for reviewer] there is now 7 headers when only 6 were previously reported, here we don't really have a strict assertion on all of them, only a few are expected with specific values as seen in the assertions just below.