Skip to content

Add note that number and boolean labels require APM Server 6.7+ #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2019
Merged

Add note that number and boolean labels require APM Server 6.7+ #608

merged 4 commits into from
Apr 24, 2019

Conversation

@felixbarny
Copy link
Member

@felixbarny felixbarny commented Apr 24, 2019

No description provided.

@felixbarny felixbarny self-assigned this Apr 24, 2019
@felixbarny felixbarny requested a review from eyalkoren April 24, 2019 06:05
@codecov-io
Copy link

codecov-io commented Apr 24, 2019

Codecov Report

Merging #608 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #608      +/-   ##
============================================
- Coverage     62.42%   62.41%   -0.02%     
  Complexity       68       68              
============================================
  Files           188      188              
  Lines          7074     7074              
  Branches        816      816              
============================================
- Hits           4416     4415       -1     
- Misses         2389     2390       +1     
  Partials        269      269
Impacted Files Coverage Δ Complexity Δ
...gent/servlet/wildfly/WildFlyLifecycleListener.java 85.71% <0%> (-14.29%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 337e5ff...a85cdda. Read the comment docs.

@felixbarny felixbarny changed the title Add note that number and boolean labels requere APM Server 6.7+ Add note that number and boolean labels require APM Server 6.7+ Apr 24, 2019
eyalkoren
eyalkoren reviewed Apr 24, 2019
View reviewed changes
eyalkoren and others added 2 commits April 24, 2019 09:25
@felixbarny
Copy link
Member Author

felixbarny commented Apr 24, 2019

related to elastic/apm#42 (comment)

felixbarny
felixbarny commented Apr 24, 2019
View reviewed changes
@felixbarny felixbarny merged commit 42e951b into elastic:master Apr 24, 2019
@felixbarny felixbarny deleted the number-boolean-labels-version-warning branch April 24, 2019 13:59
@felixbarny felixbarny mentioned this pull request Apr 24, 2019
Closed
7 tasks
@felixbarny felixbarny added docs Documentation and removed [zube]: Done labels Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eyalkoren eyalkoren eyalkoren approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@felixbarny felixbarny

Labels

docs Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felixbarny @codecov-io @eyalkoren