Stabilizing JMS tests #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #663 +/- ##
=========================================
Coverage 62.11% 62.11%
Complexity 68 68
=========================================
Files 199 199
Lines 7719 7719
Branches 947 947
=========================================
Hits 4795 4795
Misses 2627 2627
Partials 297 297Continue to review full report at Codecov.
|
felixbarny
reviewed
Jun 12, 2019
| } | ||
|
|
||
| // A utility method for testing the receiveNoWait API consistently | ||
| private Message loopReceive(Callable<Message> receiveMethod, @SuppressWarnings("SameParameterValue") long timeout) throws Exception { |
Contributor
Author
There was a problem hiding this comment.
Nice! But let's merge this now, and consider next time?
felixbarny
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.