Supporting SpringMapMessageListener #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalkoren
commented
Jul 9, 2019
apm-agent-core/src/main/java/co/elastic/apm/agent/impl/transaction/TraceContext.java
Show resolved
Hide resolved
felixbarny
reviewed
Jul 10, 2019
felixbarny
reviewed
Jul 10, 2019
...apm-jms-plugin/src/main/java/co/elastic/apm/agent/jms/JmsMessageListenerInstrumentation.java
Show resolved
Hide resolved
felixbarny
approved these changes
Jul 15, 2019
Member
felixbarny
left a comment
felixbarny
left a comment
There was a problem hiding this comment.
Missing changelog (and supported-technologies update?), otherwise LGTM
eyalkoren
force-pushed
the
jms-spring-support
branch
from
c9b2a6f to
00964bc
Compare
Contributor
Author
|
@felixbarny Added to CHANGELOG, but I am not sure about adding to supported technologies. |
Codecov Report
@@ Coverage Diff @@
## master #714 +/- ##
=========================================
Coverage 61.75% 61.75%
Complexity 94 94
=========================================
Files 202 202
Lines 8083 8083
Branches 1005 1005
=========================================
Hits 4992 4992
Misses 2786 2786
Partials 305 305Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #710