Skip to content

Conversation

@felixbarny
Copy link
Member

@felixbarny felixbarny commented May 7, 2018

DetachedThreadLocals allocate objects on each lookup

As DetachedThreadLocals allocate objects on each lookup
@codecov-io
Copy link

Codecov Report

Merging #78 into master will decrease coverage by 0.24%.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #78      +/-   ##
============================================
- Coverage     76.43%   76.19%   -0.25%     
+ Complexity      737      736       -1     
============================================
  Files            79       79              
  Lines          2674     2680       +6     
  Branches        241      242       +1     
============================================
- Hits           2044     2042       -2     
- Misses          497      504       +7     
- Partials        133      134       +1
Impacted Files Coverage Δ Complexity Δ
...lastic/apm/objectpool/impl/AbstractObjectPool.java 56.25% <ø> (ø) 3 <0> (ø) ⬇️
...tic/apm/objectpool/impl/ThreadLocalObjectPool.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ain/java/co/elastic/apm/impl/ElasticApmTracer.java 81.42% <100%> (ø) 40 <4> (ø) ⬇️
...a/co/elastic/apm/report/ReportingEventHandler.java 92.59% <0%> (-7.41%) 9% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ea6440...69041ef. Read the comment docs.

@felixbarny felixbarny merged commit 8237da9 into elastic:master May 7, 2018
@felixbarny felixbarny deleted the vanilla-thread-local branch May 7, 2018 10:19
@alvarolobato alvarolobato added this to the Beta milestone May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants