Skip to content

Conversation

@felixbarny
Copy link
Member

This should decrease the frequency of security alerts

This should decrease the frequency of security alerts
@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #909 into master will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #909      +/-   ##
============================================
+ Coverage     64.03%   64.38%   +0.34%     
  Complexity       85       85              
============================================
  Files           234      234              
  Lines          9685     9802     +117     
  Branches       1263     1284      +21     
============================================
+ Hits           6202     6311     +109     
- Misses         3095     3099       +4     
- Partials        388      392       +4
Impacted Files Coverage Δ Complexity Δ
...va/co/elastic/apm/agent/impl/transaction/Span.java 79.56% <0%> (+2.03%) 0% <0%> (ø) ⬇️
...astic/apm/agent/impl/transaction/AbstractSpan.java 83.58% <0%> (+3.43%) 0% <0%> (ø) ⬇️
...co/elastic/apm/agent/report/ApmServerReporter.java 60.95% <0%> (+3.8%) 0% <0%> (ø) ⬇️
...va/co/elastic/apm/agent/report/ReportingEvent.java 96.66% <0%> (+10%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d5617...0a765bc. Read the comment docs.

@felixbarny felixbarny requested a review from eyalkoren October 30, 2019 10:38
@eyalkoren
Copy link
Contributor

JobTransactionNameInstrumentationTest failure doesn't seem related:

org.quartz.SchedulerException: Unable to unschedule trigger [DEFAULT.myTrigger] while deleting job [DEFAULT.dummyJobName]
	at org.quartz.core.QuartzScheduler.deleteJob(QuartzScheduler.java:966)
	at org.quartz.impl.StdScheduler.deleteJob(StdScheduler.java:301)
	at co.elastic.apm.agent.quartz.job.JobTransactionNameInstrumentationTest.testJobWithoutGroup(JobTransactionNameInstrumentationTest.java:109)

🤔

@eyalkoren
Copy link
Contributor

Jenkins run the tests

@eyalkoren eyalkoren merged commit 835adc6 into elastic:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants