Skip to content

test: fix setup of benchmarks in CI on new CPU models #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 6, 2022
Merged

test: fix setup of benchmarks in CI on new CPU models #2804

merged 3 commits into from
Jul 6, 2022

Conversation

@trentm
Copy link
Member

@trentm trentm commented Jul 4, 2022 •
edited
Loading

"12th Gen Intel(R) Core(TM) i5-12500" is a new CPU model appearing in CI
benchmark runs in the last week.

This should fix recent "Benchmarks" CI failures, e.g. https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/main/265/pipeline

...
[2022-06-30T18:44:11.560Z] + setUp
[2022-06-30T18:44:11.560Z] + echo 'Setting CPU frequency to base frequency'
[2022-06-30T18:44:11.560Z] Setting CPU frequency to base frequency
[2022-06-30T18:44:11.560Z] ++ lscpu
[2022-06-30T18:44:11.560Z] ++ grep 'Model name'
[2022-06-30T18:44:11.560Z] ++ awk '{for(i=3;i<=NF;i++){printf "%s ", $i}; printf "\n"}'
[2022-06-30T18:44:11.560Z] + CPU_MODEL='12th Gen Intel(R) Core(TM) i5-12500 '
[2022-06-30T18:44:11.560Z] + '[' '12th Gen Intel(R) Core(TM) i5-12500 ' == 'Intel(R) Xeon(R) CPU E3-1246 v3 @ 3.50GHz ' ']'
[2022-06-30T18:44:11.560Z] + '[' '12th Gen Intel(R) Core(TM) i5-12500 ' == 'Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz ' ']'
[2022-06-30T18:44:11.560Z] + '[' '12th Gen Intel(R) Core(TM) i5-12500 ' == 'Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz ' ']'
[2022-06-30T18:44:11.560Z] + '[' '12th Gen Intel(R) Core(TM) i5-12500 ' == 'Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz ' ']'
[2022-06-30T18:44:11.560Z] + echo 'Cannot determine base frequency for CPU model [12th Gen Intel(R) Core(TM) i5-12500 ]. Please adjust the build script.'
[2022-06-30T18:44:11.560Z] Cannot determine base frequency for CPU model [12th Gen Intel(R) Core(TM) i5-12500 ]. Please adjust the build script.
[2022-06-30T18:44:11.560Z] + exit 1
[2022-06-30T18:44:11.560Z] + tearDown
[2022-06-30T18:44:11.560Z] + echo 'Destroying cgroups'
[2022-06-30T18:44:11.561Z] Destroying cgroups
[2022-06-30T18:44:11.561Z] + sudo -n cset set --destroy /os
[2022-06-30T18:44:11.662Z] cset: **> cpuset "/os" not found in cpusets
[2022-06-30T18:44:11.662Z] npm ERR! code ELIFECYCLE
[2022-06-30T18:44:11.662Z] npm ERR! errno 2
...

See elastic/apm-agent-java#2693 which is the same issue for the Java APM agent.

@trentm
test: fix setup of benchmarks in CI on new CPU models
9bf21aa 
"12th Gen Intel(R) Core(TM) i5-12500" is a new CPU model appearing in CI
benchmark runs in the last week. The "... i7-8665U ..." model is being
added from the equivalent 'setUp()' implementation in apm-agent-java.
@trentm trentm requested a review from astorm July 4, 2022 20:32
@trentm trentm self-assigned this Jul 4, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jul 4, 2022
@ghost
Copy link

ghost commented Jul 4, 2022 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-05T16:24:00.685+0000

  • Duration: 20 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 256941
Skipped 0
Total 256941

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm
Copy link
Member Author

trentm commented Jul 4, 2022

A benchmark run passed now: https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/PR-2804/2/pipeline/158

@trentm trentm merged commit f313f13 into main Jul 6, 2022
@trentm trentm deleted the trentm/fix-benchmarks-new-cpu-model branch July 6, 2022 17:30
v1v added a commit to v1v/apm-agent-nodejs that referenced this pull request Jul 6, 2022
@v1v
Merge branch 'main' of github.com:elastic/apm-agent-nodejs into featu…
a9b0032 
…re/test-opentelemetry-actions

* 'main' of github.com:elastic/apm-agent-nodejs:
  chore(deps): bump moment from 2.29.3 to 2.29.4 (elastic#2813)
  chore(deps-dev): bump @types/node from 18.0.1 to 18.0.3 (elastic#2806)
  chore: bump to got@11.8.5 for vuln fix (elastic#2787)
  test: fix setup of benchmarks in CI on new CPU models (elastic#2804)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@astorm astorm astorm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@trentm trentm

Labels

agent-nodejs Make available for APM Agents project planning.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trentm @astorm