Skip to content

Conversation

@trentm
Copy link
Member

@trentm trentm commented Mar 2, 2023

  • Avoid test, lint, & edge CI workflows for .md and .asciidoc changes in
    any subdir.
  • Tweak the "types" test (npm run test:types) to catch the case of
    apm.flush() with no callback returning a promise.

- Avoid test, lint, & edge CI workflows for .md and .asciidoc changes in
  any subdir.
- Tweak the "types" test (npm run test:types) to catch the case of
  `apm.flush()` with no callback returning a promise.
@trentm trentm self-assigned this Mar 2, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Mar 2, 2023
@ghost
Copy link

ghost commented Mar 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-03-02T20:03:51.940+0000

  • Duration: 23 min 6 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm merged commit 63b6eca into main Mar 2, 2023
@trentm trentm deleted the trentm/test-refactor-small-things branch March 2, 2023 20:28
v1v added a commit to v1v/apm-agent-nodejs that referenced this pull request Mar 21, 2023
* upstream/main: (44 commits)
  action: abort builds when new commit (elastic#3196)
  docs: note that 3.40.0 was bad release (elastic#3194)
  chore(deps-dev): bump @babel/cli from 7.20.7 to 7.21.0 (elastic#3170)
  chore(deps-dev): bump @babel/core from 7.20.2 to 7.21.0 (elastic#3169)
  ci: drop max-parallel for GH actions (elastic#3191)
  test: correct sense of test message (elastic#3186)
  3.43.0 (elastic#3184)
  test, ci: some small changes (elastic#3183)
  ci: limit parallel GH Action test runs to try to avoid 429 errors on checkout (elastic#3180)
  fix: transaction name for Next.js API routes in next@13.2 was broken (elastic#3178)
  mongodb@5 support (elastic#3177)
  chore(deps-dev): bump body-parser from 1.20.1 to 1.20.2 (elastic#3171)
  chore(deps-dev): bump restify from 11.0.0 to 11.1.0 (elastic#3172)
  docs: minor fix in README for Azure Functions example (elastic#3175)
  feat: Make Agent.flush() return a Promise if no callback is passed as param (elastic#3167)
  chore(deps-dev): bump @types/node from 18.11.9 to 18.14.0 (elastic#3165)
  chore(deps-dev): bump @hapi/hapi from 21.2.1 to 21.3.0 (elastic#3166)
  chore(deps-dev): bump undici from 5.19.1 to 5.20.0 (elastic#3164)
  chore(deps-dev): bump fastify from 4.12.0 to 4.13.0 (elastic#3154)
  Use composite action for updatecli workflow (elastic#3162)
  ...
@trentm trentm mentioned this pull request Mar 24, 2023
1 task
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
- Avoid test, lint, & edge CI workflows for .md and .asciidoc changes in
  any subdir.
- Tweak the "types" test (npm run test:types) to catch the case of
  `apm.flush()` with no callback returning a promise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-nodejs Make available for APM Agents project planning.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants