Skip to content

Conversation

fr4nc1sc0-r4m0n
Copy link
Contributor

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n commented Sep 11, 2025

Summary

This PR contains basically two changes:

  1. Fix google secrets project to the elastic-observability-ci
  2. Add the project-id argument in the google authentication to avoid references to default elastic-observability project

This is part of https://github.com/elastic/observability-robots/issues/2797

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n self-assigned this Sep 11, 2025
@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n requested a review from a team as a code owner September 11, 2025 08:40
@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n added the bug Something isn't working label Sep 11, 2025
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Sep 11, 2025
dmathieu
dmathieu previously approved these changes Sep 11, 2025
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we test these changes in a test feature branch and run https://github.com/elastic/apm-aws-lambda/actions/workflows/smoke-tests.yml manually?

@fr4nc1sc0-r4m0n
Copy link
Contributor Author

After executing the smoke-tests.yml ee realized the secrets modules are only managing permissions on the elastic-observability project. So issue opened here:

@fr4nc1sc0-r4m0n
Copy link
Contributor Author

Now seems that is working fine. Tested here:

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n merged commit 03329c9 into elastic:main Sep 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants