This repository was archived by the owner on Jan 23, 2024. It is now read-only.
Adds a basic agent remote config test. #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalvz
force-pushed
the
python-agent-config-test
branch
from
763558d to
fa55e41
Compare
kuisathaverat
approved these changes
Oct 21, 2019
graphaelli
approved these changes
Oct 21, 2019
tests/agent/__init__.py
Outdated
|
|
||
|
|
||
| @contextmanager | ||
| def remote_config(url, sampling_rate=1.0): |
Member
There was a problem hiding this comment.
since url is used a lot I think it should be more descriptive, how about kibana_url ?
scripts/tests/localsetup_tests.py
Outdated
| -E, setup.template.settings.index.number_of_shards=1, -E, setup.template.settings.index.refresh_interval=1ms, | ||
| -E, monitoring.elasticsearch=true, -E, monitoring.enabled=true, | ||
| -E, apm-server.kibana.enabled=true, -E, 'apm-server.kibana.host=kibana:5601', | ||
| -E, apm-server.kibana.enabled=true, -E, apm-server.agent.config.cache.expiration=2s, -E, 'apm-server.kibana.host=kibana:5601', |
Member
There was a problem hiding this comment.
any reason the expiry can't be even shorter?
Contributor
Author
There was a problem hiding this comment.
im fine with 1s, since this is going to be used for opbeans and everything else I didn't want it to be too noisy
Co-Authored-By: Ivan Fernandez Calvo <kuisathaverat@users.noreply.github.com>
This was referenced Oct 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #436