-
Notifications
You must be signed in to change notification settings - Fork 124
Update Kubernetes pod UID parsing spec #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Kubernetes pod UID parsing spec #678
Conversation
eyalkoren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think you make this PR ready for review.
Can you provide a couple of examples for /proc/self/cgroup file lines that we can use for unit testing?
Thanks, will do!
In |
I think it makes sense to add a common json test spec in https://github.com/elastic/apm/tree/main/tests/agents/json-specs for this. I don't see this as blocking this PR, though. |
Make sense, I wasn't aware this existed though :-) |
sanitize_field_names)CODEOWNERS)