-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with override path in cgroups #27620
Fix bug with override path in cgroups #27620
Conversation
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fearful-symmetry!
Is there a handy place I can snag the linux binary? I should be able to test it on my cloud deployment. |
@matschaffer Not before the merge of the PR. But I can build it for you or tell you how to build it ;-) |
/test |
This pull request is now in conflicts. Could you fix it? 🙏
|
…verride-logic-fix
FWIW, I tested this with this small program - ran it before/after changes in a Docker container: package main
import (
"fmt"
"log"
"github.com/elastic/beats/v7/libbeat/cmd/instance/metrics"
"github.com/elastic/beats/v7/libbeat/monitoring"
)
func main() {
if err := metrics.SetupMetrics("testing"); err != nil {
log.Fatal(err)
}
snapshot := monitoring.CollectFlatSnapshot(monitoring.Default, monitoring.Full, false)
for name, value := range snapshot.Ints {
fmt.Println(name, value)
}
} I think we're good, and can just wait for the next BC after this merges. |
Yep, sorry for the delay, once again fighting with CI... |
/test |
FINALLY |
* fix bug with override path * add changelog (cherry picked from commit f073c45)
* fix bug with override path * add changelog (cherry picked from commit f073c45)
* master: Forward port 7.14.1 changelog to master (elastic#27687) Addressing multiple dashboard issues: deps loading once, field conversion, etc. (elastic#27669) Remove adaptive queue sizes from agent's spec files (elastic#27653) Osquerybeat: Improve testability and unit test coverage (elastic#27591) Osquerybeat: lockdown flagsfile, prevent global defaults (elastic#27611) Import the references of dashboard assets using the Saved Objects API (elastic#27647) Fix bug with override path in cgroups (elastic#27620) Allow Kibana client to authorize with Elasticsearch API key (elastic#27540) Filebeat auditd: Fix Top Exec Commands dashboard visualization (elastic#27638) [elastic-agent] Fix docker tar.gz generation for complete image (elastic#27621) Follow up changes in dashboards in mage check && fix minor issue (elastic#27553) [Heartbeat] Fix bug where `enabled: false` is ignored. (elastic#27615) Support kube_state_metrics v2.0.0 (elastic#27552)
* fix bug with override path * add changelog
What does this PR do?
This is a fix for #27598
In cases where
cgroupsHierarchyOverride
is set to/
, andignoreRootCgroups
is set, we'll just completely bypass any cgroups reporting.Why is it important?
It's a bug that was breaking containers.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
http.enabled
to true in the beat configcurl localhost:5066/stats?pretty
Related issues