Import the references of dashboard assets using the Saved Objects API #27647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
removed
the
needs_team
kvch
added
backport-v7.15.0
jsoriano
reviewed
Aug 30, 2021
| @@ -69,7 +69,7 @@ func KibanaDashboards(moduleDirs ...string) error { | |||
| // Convert 7.x dashboards to strings. | |||
| err = sh.Run(pythonExe, | |||
| filepath.Join(esBeatsDir, "libbeat/scripts/unpack_dashboards.py"), | |||
There was a problem hiding this comment.
Oh, a script we should migrate to go (not now 🙂).
| continue | ||
| } | ||
| referencePath := filepath.Join(base, "..", ref.Type, ref.ID+".json") | ||
| err := loader.ImportDashboard(referencePath) |
There was a problem hiding this comment.
Adrian mentioned that Kibana "fails" with status 200 if it cannot import any dashboard because of missing references. Should we check the content of the response in ImportDashboards so we detect this kind of issues earlier?
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
jsoriano
approved these changes
Aug 30, 2021
| if !kibanaResult.Success { | ||
| var errs multierror.Errors | ||
| for _, err := range kibanaResult.Errors { | ||
| errs = append(errs, fmt.Errorf("error: %s, asset ID=%s; asset type=%s; references=%+v", err.Error.Type, err.Id, err.Type, err.Error.References)) |
There was a problem hiding this comment.
I guess that there can be other types of errors here, and other errors may not have anything to do with references, so err.Error.Refereces will be nil. But we can revisit this later if we find this is problematic, or we need to get more info for for other kinds of errors.
There was a problem hiding this comment.
The whole error parsing from Kibana is very fragile, so I agree. I have removed the previous error check because it is just going to break. It would be nice if we could get HTTP errors when errors do happen: e.g. missing references.
kvch
added a commit
that referenced
this pull request
Aug 31, 2021
…#27647) (#27664) ## What does this PR do? This PR changes the dashboard loading by first loading its references and then loading the dashboards. ## Why is it important? If the assets are not loaded in the proper order, the import can fail with unknown references. (cherry picked from commit b90370d) Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
kvch
added a commit
that referenced
this pull request
Sep 1, 2021
…#27647) (#27665) This PR changes the dashboard loading by first loading its references and then loading the dashboards. If the assets are not loaded in the proper order, the import can fail with unknown references. (cherry picked from commit b90370d) Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
mdelapenya
added a commit
to mdelapenya/beats
that referenced
this pull request
Sep 1, 2021
* master: Forward port 7.14.1 changelog to master (elastic#27687) Addressing multiple dashboard issues: deps loading once, field conversion, etc. (elastic#27669) Remove adaptive queue sizes from agent's spec files (elastic#27653) Osquerybeat: Improve testability and unit test coverage (elastic#27591) Osquerybeat: lockdown flagsfile, prevent global defaults (elastic#27611) Import the references of dashboard assets using the Saved Objects API (elastic#27647) Fix bug with override path in cgroups (elastic#27620) Allow Kibana client to authorize with Elasticsearch API key (elastic#27540) Filebeat auditd: Fix Top Exec Commands dashboard visualization (elastic#27638) [elastic-agent] Fix docker tar.gz generation for complete image (elastic#27621) Follow up changes in dashboards in mage check && fix minor issue (elastic#27553) [Heartbeat] Fix bug where `enabled: false` is ignored. (elastic#27615) Support kube_state_metrics v2.0.0 (elastic#27552)
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
…elastic#27647) ## What does this PR do? This PR changes the dashboard loading by first loading its references and then loading the dashboards. ## Why is it important? If the assets are not loaded in the proper order, the import can fail with unknown references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the dashboard loading by first loading its references and then loading the dashboards.
Why is it important?
If the assets are not loaded in the proper order, the import can fail with unknown references.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.