feat: es-schema module poc #232
Merged
Merged
Conversation
✅MegaLinter analysis: Success
See detailed reports in MegaLinter artifacts MegaLinter is graciously provided by OX Security |
JoshMock
approved these changes
Apr 28, 2026
Member
JoshMock
left a comment
There was a problem hiding this comment.
LGTM!
As with #227, we can work on actually publishing stuff in packages/ to npm as standalone packages later. Just validating that extracting the code out of the critical path works correctly is a win.
Also note that the work in #79 will need to be modified to include this codegen work. Whichever PR gets merged first will inform how we go about that.
2041db4 to
d368efa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/es/apis/schemas/into a new@elastic/es-schemasworkspace package underpackages/es-schemas/@elastic/es-schemastsc -p packages/es-schemas && tsc) to compile the sub-package first@elastic/es-schemasto Release Please config for independent versioningMotivation
Closes #78. Makes the Zod request schemas independently consumable by other tools (e.g. Kibana Workflows, external validators) without depending on the full CLI.
What changed
src/es/apis/schemas/*.tspackages/es-schemas/src/*.ts./schemas/<stem>.ts@elastic/es-schemas/<stem>.jstsctsc -p packages/es-schemas && tscsrc/es/apis/schemas/**src/)Follow-ups
elastic-client-generator-jsto emit@elastic/es-schemasimports@elastic/es-schemasonce versioning is finalizedTest plan
npm run buildcompiles both packagesnpm testpasses (unit + license check)tsc --noEmittypechecks cleanlyelastic-client-generator-jspass with updated import paths-wflag conflict)