Skip to content

[Bug] CLI Create Rule Crash #3096

@ghost

Description

Describe the bug
CLI create-rule is defect with required fields

To Reproduce
python -m detection_rules create-rule test
Rule type (query, saved_query, machine_learning, eql, threshold, threat_match, new_terms): query
actions (multi, comma separated): any value
Crash of code:
Traceback (most recent call last): File "<frozen runpy>", line 198, in _run_module_as_main File "<frozen runpy>", line 88, in _run_code File "/home/densanki/Documents/detection-rules/detection_rules/__main__.py", line 34, in <module> main() File "/home/densanki/Documents/detection-rules/detection_rules/__main__.py", line 31, in main root(prog_name="detection_rules") File "/home/densanki/Documents/detection-rules/.venv/lib/python3.11/site-packages/click/core.py", line 1157, in __call__ return self.main(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/densanki/Documents/detection-rules/.venv/lib/python3.11/site-packages/click/core.py", line 1078, in main rv = self.invoke(ctx) ^^^^^^^^^^^^^^^^ File "/home/densanki/Documents/detection-rules/.venv/lib/python3.11/site-packages/click/core.py", line 1688, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/densanki/Documents/detection-rules/.venv/lib/python3.11/site-packages/click/core.py", line 1434, in invoke return ctx.invoke(self.callback, **ctx.params) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/densanki/Documents/detection-rules/.venv/lib/python3.11/site-packages/click/core.py", line 783, in invoke return __callback(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/densanki/Documents/detection-rules/detection_rules/main.py", line 56, in create_rule return rule_prompt(path, rule_type=rule_type, required_only=required_only, save=True, **contents) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/densanki/Documents/detection-rules/detection_rules/cli_utils.py", line 169, in rule_prompt result = schema_prompt(name, required=name in required_fields, **options.copy()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: detection_rules.misc.schema_prompt() got multiple values for keyword argument 'required'

Expected behavior
Create Rule should run without exception

Screenshots
image

Desktop (please complete the following information):

  • OS: Ubuntu
  • Version: 23.04 / Linux 6.2.0-32-generic

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions