Skip to content

Modify Unit Test to Support Alert Suppression for EQL Sequences #4457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Modify Unit Test to Support Alert Suppression for EQL Sequences #4457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
286e3c2
Modify Unit Test to Support Alert Suppression for EQL Sequences
shashank-elastic Feb 12, 2025
dff50ea
Update Patch Version
shashank-elastic Feb 12, 2025
c07663b
Ignore W504 line break after binary operator check
shashank-elastic Feb 12, 2025
bcb36be
Redo comment
shashank-elastic Feb 12, 2025
9b35dd4
Lint issues
shashank-elastic Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "detection_rules"
version = "0.4.10"
version = "0.4.11"
description = "Detection Rules is the home for rules used by Elastic Security. This repository is used for the development, maintenance, testing, validation, and release of rules for Elastic Security’s Detection Engine."
readme = "README.md"
requires-python = ">=3.12"
Expand Down
5 changes: 3 additions & 2 deletions tests/test_all_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1449,8 +1449,9 @@ def test_group_field_in_schemas(self):
self.fail(f"{self.rule_str(rule)} alert suppression field {fld} not \
found in ECS, Beats, or non-ecs schemas")

@unittest.skipIf(PACKAGE_STACK_VERSION < Version.parse("8.14.0"),
"Test only applicable to 8.14+ stacks for eql non-sequence rule alert suppression feature.")
@unittest.skipIf(PACKAGE_STACK_VERSION < Version.parse("8.14.0") or # noqa: W504
PACKAGE_STACK_VERSION >= Version.parse("8.18.0"), # noqa: W504
"Test is applicable to 8.14 --> 8.17 stacks for eql non-sequence rule alert suppression feature.")
def test_eql_non_sequence_support_only(self):
for rule in self.all_rules:
if (
Expand Down
Loading