-
Notifications
You must be signed in to change notification settings - Fork 603
[Rule Tuning] Windows 3rd Party EDR Compatibility - Part 7 #5022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
⛔️ Test failed Results
|
@@ -1,8 +1,8 @@ | |||
[metadata] | |||
creation_date = "2020/09/09" | |||
integration = ["windows", "system", "sentinel_one_cloud_funnel", "m365_defender"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integration = ["windows", "system", "sentinel_one_cloud_funnel", "m365_defender"] | |
integration = ["endpoint", "windows", "system", "sentinel_one_cloud_funnel", "m365_defender"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI CS can also be added by making the exclusion by parent.executable optional this rule is related to one of the top TTPs https://github.com/elastic/detection-rules/pull/5001/files#diff-8c40e59c5638910d4a38ec146c0076b58f27eddc05eca33cae6bed157b3baf84R3 (should be addressed by this PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the changes doesn't conflict between our PRs, I'll keep this one as is and we can add Defend and CS at yours
registry.path : ( | ||
"HKLM\\SYSTEM\\*ControlSet*\\Services\\*\\Start", | ||
"\\REGISTRY\\MACHINE\\SYSTEM\\*ControlSet*\\Services\\*\\Start", | ||
"MACHINE\\SYSTEM\\*ControlSet*\\Services\\*\\Start" | ||
) and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@w0rk3r CS regmod paths is \\REGISTRY\\MACHINE\\SYSTEM\\*
why remove this in favor of a generic wildcard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To simplify the query, unless this could cause any FPs. Performance should be similar or better as doing multiple wildcards 3 times should be expensive
[metadata] | ||
creation_date = "2020/11/15" | ||
integration = ["endpoint", "windows", "m365_defender"] | ||
integration = ["endpoint", "windows", "m365_defender", "crowdstrike"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@w0rk3r I would suggest to also add sentinel1 and 4688 compat here by removing this sub-condition from the query length(process.pe.original_file_name) > 5
(any short program like a.exe
is suspicious)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this is better as a separated rule? Sounds like a diff logic
⛔️ Test failed Results
|
Issue
Related (but not limited) to https://github.com/elastic/ia-trade-team/issues/498
Summary
This PR is part of a series that adds compatibility for additional data sources, including CrowdStrike, SentinelOne, Microsoft Defender for Endpoint, Endgame, and Sysmon.
To review this PR, you can use the EDR Field Compatibility Matrix, which details field compatibility for each event.category across EDR data sources.
Some changes go beyond metadata and include logic updates to optimize, simplify, or account for differences between data sources (For example, CrowdStrike uses NT Object paths for Windows paths instead of drive letters.). Please review these cases with extra attention, and don’t hesitate to ask questions.