Skip to content

Conversation

terrancedejesus
Copy link
Contributor

Fixes #5009

Pull Request

Issue link(s):

Summary - What I changed

Tunes anomalous M365 portal login rules for false-positives. Please see related issue for details on changes.

How To Test

Queries can be used in alert telemetry or TRADE stack for testing. Alert telemetry cluster will show a significant decrease in FP alerts with no exclusions/inclusions.

Checklist

  • Added a label for the type of pr: bug, enhancement, schema, maintenance, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
  • Added the meta:rapid-merge label if planning to merge within 24 hours
  • Secret and sensitive material has been managed correctly
  • Automated testing was updated or added to match the most common scenarios
  • Documentation and comments were added for features that require explanation

Contributor checklist

Copy link
Contributor

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

terrancedejesus and others added 2 commits August 29, 2025 11:11
…gin_from_rare_location.toml

Co-authored-by: Samirbous <64742097+Samirbous@users.noreply.github.com>
…e_travel_portal_logins.toml

Co-authored-by: Samirbous <64742097+Samirbous@users.noreply.github.com>
@terrancedejesus terrancedejesus merged commit d9151c3 into main Aug 29, 2025
11 checks passed
@terrancedejesus terrancedejesus deleted the terrancedejesus/issue5009 branch August 29, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Rule Tuning] M365 Portal Logins (Impossible & Atypical)

4 participants