-
Notifications
You must be signed in to change notification settings - Fork 603
Tune Rules that have unsupported versions in min_stack_version #5079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes unsupported min_stack_version
fields from three detection rules as part of rule tuning. The changes ensure rules no longer reference stack versions that don't exist or are invalid, addressing test case failures identified in the parent PR.
- Removed
min_stack_version
andmin_stack_comments
fields from rule metadata - Updated
updated_date
fields to reflect the tuning changes - Standardized the removal across Azure and AWS integration rules
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
rules/integrations/azure/credential_access_entra_id_brute_force_activity.toml | Removed min_stack_version "8.17.0" and associated comments |
rules/integrations/aws/privilege_escalation_iam_update_assume_role_policy.toml | Removed min_stack_version "8.16.5" and associated comments |
rules/integrations/aws/privilege_escalation_iam_customer_managed_policy_attached_to_role.toml | Removed min_stack_version "8.16.5" and associated comments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Pull Request
Issue link(s): NA
Summary - What I changed
How To Test
Checklist
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist