Skip to content

Conversation

w0rk3r
Copy link
Contributor

@w0rk3r w0rk3r commented Sep 12, 2025

Summary

Fix broken process.pe.original_file_name conditions.

@w0rk3r w0rk3r self-assigned this Sep 12, 2025
@w0rk3r w0rk3r added Rule: Tuning tweaking or tuning an existing rule OS: Windows windows related rules Domain: Endpoint backport: auto labels Sep 12, 2025
Copy link
Contributor

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

  • Detailed description of the suggested changes.
  • Provide example JSON data or screenshots.
  • Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
  • Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
  • Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
  • Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
  • Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
  • Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
  • Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
  • Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
  • Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
  • Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

  • updated_date matches the date of tuning PR merged.
  • min_stack_version should support the widest stack versions.
  • name and description should be descriptive and not include typos.
  • query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

  • Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
  • Ensure that the tuned rule has a low false positive rate.

@tradebot-elastic
Copy link

tradebot-elastic commented Sep 12, 2025

⛔️ Test failed

Results
  • ❌ Windows Defender Exclusions Added via PowerShell (eql)
    • validation_missing: No tests ran
  • ❌ ScreenConnect Server Spawning Suspicious Processes (eql)
    • coverage_issue: no_rta
    • validation_missing: No tests ran
  • ❌ Encrypting Files with WinRar or 7z (eql)
    • validation_missing: No tests ran
  • ❌ Disable Windows Event and Security Logs Using Built-in Tools (eql)
    • validation_missing: No tests ran
  • ❌ Clearing Windows Console History (eql)
    • validation_missing: No tests ran
  • ❌ Disabling Windows Defender Security Settings via PowerShell (eql)
    • validation_missing: No tests ran
  • ❌ Clearing Windows Event Logs (eql)
    • validation_missing: No tests ran
  • ❌ Windows Firewall Disabled via PowerShell (eql)
    • validation_missing: No tests ran
  • ❌ Microsoft Exchange Worker Spawning Suspicious Processes (eql)
    • coverage_issue: no_rta
    • validation_missing: No tests ran

(
process.name : ("powershell.exe", "pwsh.exe", "powershell_ise.exe") or
?process.pe.original_file_name in ("powershell.exe", "pwsh.dll", "powershell_ise.exe")
?process.pe.original_file_name in ("PowerShell.EXE", "pwsh.dll", "powershell_ise.EXE")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these original names OS-version independent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, I've looked up them in telemetry, and these are the expected ones

@tradebot-elastic
Copy link

tradebot-elastic commented Sep 15, 2025

⛔️ Test failed

Results
  • ✅ Windows Defender Exclusions Added via PowerShell (eql)
  • ❌ ScreenConnect Server Spawning Suspicious Processes (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta
  • ❌ Encrypting Files with WinRar or 7z (eql)
    • stack_validation_failed: no_alerts - 0 alerts
  • ✅ Disable Windows Event and Security Logs Using Built-in Tools (eql)
  • ✅ Clearing Windows Console History (eql)
  • ✅ Disabling Windows Defender Security Settings via PowerShell (eql)
  • ✅ Clearing Windows Event Logs (eql)
  • ✅ Windows Firewall Disabled via PowerShell (eql)
  • ❌ Microsoft Exchange Worker Spawning Suspicious Processes (eql)
    • coverage_issue: no_rta
    • stack_validation_failed: no_rta

@w0rk3r w0rk3r merged commit 8d9822e into main Sep 15, 2025
21 of 26 checks passed
@w0rk3r w0rk3r deleted the rt_original_file_name branch September 15, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport: auto Domain: Endpoint OS: Windows windows related rules Rule: Tuning tweaking or tuning an existing rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants