Skip to content

Update link to previous versions #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Update link to previous versions #1104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Elastic.Markdown/Slices/Layout/_LandingPage.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,8 @@
<h3 class="font-sans font-bold text-2xl">Previous versions</h3>
<p class="grow mt-4">Browse the docs for previous Elastic product versions.</p>
<div class="mt-6">
<a href="@Model.Link("/guide")" target="_blank" rel="noopener noreferrer" class="link text-white">
View archive docs
<a href="https://www.elastic.co/guide" target="_blank" rel="noopener noreferrer" class="link text-white">
Copy link
Member Author

@bmorelli25 bmorelli25 Apr 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/docs-engineering I'm not sure if this is correct. It seems @Model.Link(" substitutes elastic.co/docs in. In this case, I don't want to link to a /docs page. Is this the correct way to do this? The unfortunate thing is that the link is not environment aware.

Should I do <a href="/guide" instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full URL seems good.

View previous versions
<svg class="link-arrow"
xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke-width="1.5" stroke="currentColor">
<path stroke-linecap="round" stroke-linejoin="round" d="M17.25 8.25 21 12m0 0-3.75 3.75M21 12H3"/>
Expand Down
Loading