-
Couldn't load subscription status.
- Fork 32
Improve versioning system inference #2070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Would it be possible to put this on staging so writers who often work with non-Stack versioned docs can check the pages they are most familiar with? (Mostly thinking about @theletterf @shainaraskas 🙂) |
When this PR is merged it will automatically be deployed to our edge environment |
Hmm. So after it is merged, we have to check the edge environment quickly before the next docs-builder release in case there are any issues? |
Yeah, kind of. We don't have the ability to deploy a certain docs-builder branch yet. |
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicking again
src/Elastic.Documentation.Configuration/Versions/VersionInference.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done nitpicking :) LGTM
Closes #2018
Improves inference of the versioning system in situations where pages have no legacy URL mappings, or have different repository names from their current reference designation.