Add unit tests for AssemblyConfiguration.Match with relaxed version matching #2177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atching This commit adds comprehensive unit tests for the AssemblyConfiguration.Match method and includes a fix to support speculative builds for the previous minor version when onboarding repositories to version-based content sources. Changes: - Created new test project Elastic.Documentation.Configuration.Tests - Added 25 unit tests for AssemblyConfiguration.Match covering: - Repository validation (invalid formats, non-elastic owners) - Unknown repository handling (integration vs feature branches) - Content source matching (Current, Next, Edge, multiple sources) - Version branch speculative build logic (against current and product versions) - Fallback behavior for main/master branches - Edge cases (invalid versions, minor version 0) - Enhanced AssemblyConfiguration.Match to trigger speculative builds for version branches that match the previous minor version of the product. This supports gradual onboarding of repositories moving from non-versioned to versioned content sources. Test improvements: - Used xUnit theories to parameterize repetitive test cases - Created type alias for ContentSourceMatch for improved readability - Removed underscores from test method names - Added helper methods for cleaner test setup All 25 tests pass successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
cotti
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds comprehensive unit tests for the AssemblyConfiguration.Match
method and includes a fix to support speculative builds for the previous minor
version when onboarding repositories to version-based content sources.
Changes:
Created new test project Elastic.Documentation.Configuration.Tests
Added 25 unit tests for AssemblyConfiguration.Match covering:
Enhanced AssemblyConfiguration.Match to trigger speculative builds for
version branches that match the previous minor version of the product.
This supports gradual onboarding of repositories moving from non-versioned
to versioned content sources.
Test improvements:
All 25 tests pass successfully.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com