Fix image URLs #2193
Open
Fix image URLs #2193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| newUrl = newUrl[3..]; | ||
| offset--; | ||
| } | ||
| newUrl = Path.GetFullPath(Path.Combine(urlPathPrefix, snippet.RelativeFolder, url)) |
| if (currentUrl.LastIndexOf('/') > 0) | ||
| { | ||
| var basePath = currentUrl[..currentUrl.LastIndexOf('/')]; | ||
| newUrl = Path.GetFullPath(Path.Combine(basePath, url)); |
reakaleek
requested changes
Nov 12, 2025
Member
reakaleek
left a comment
reakaleek
left a comment
There was a problem hiding this comment.
Would testing help verify this?
Mpdreamz
requested changes
Nov 12, 2025
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
I think we can simplify this a bit using:
if (context.Build.AssemblerBuild && context.TryFindDocument(fi) is MarkdownFile currentMarkdown)
{
// Acquire navigation-aware path
if (context.PositionalNavigation.MarkdownNavigationLookup.TryGetValue(currentMarkdown, out var currentNavigation))
{
var uri = new Uri(new UriBuilder("http", "localhost", 80, currentNavigation.Url).Uri, url);
newUrl = uri.AbsolutePath;
}
else
context.EmitError($"Failed to acquire navigation for current markdown file '{currentMarkdown.FileName}' while resolving relative url '{url}'.");
}
Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com>
| else | ||
| context.EmitError($"Failed to acquire navigation for current markdown file '{currentMarkdown.FileName}' while resolving relative url '{url}'."); | ||
|
|
||
| newUrl = $"/{Path.Combine(newUrl.StartsWith(urlPathPrefix) ? string.Empty : urlPathPrefix, newUrl.TrimStart('/')) |
Member
I took a stab at creating a appropriate test for this: I was able to verify, that the test succeeds with your changes and fails without your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2190
On assembler builds, image URLs were not being adjusted to their final paths. We can access this information through the context's PositionalNavigation.