Skip to content

Fix span naming conventions #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
Merged

Fix span naming conventions #2198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df007c5
Fix span naming conventions
reakaleek Nov 12, 2025
02575ca
Merge branch 'main' into feature/span-naming
reakaleek Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api/Elastic.Documentation.Api.Core/AskAi/AskAiUsecase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class AskAiUsecase(
public async Task<Stream> AskAi(AskAiRequest askAiRequest, Cancel ctx)
{
logger.LogInformation("Starting AskAI chat with {AgentProvider} and {AgentId}", streamTransformer.AgentProvider, streamTransformer.AgentId);
var activity = AskAiActivitySource.StartActivity($"chat", ActivityKind.Client);
var activity = AskAiActivitySource.StartActivity($"chat ${streamTransformer.AgentProvider}", ActivityKind.Client);
_ = activity?.SetTag("gen_ai.operation.name", "chat");
_ = activity?.SetTag("gen_ai.provider.name", streamTransformer.AgentProvider); // agent-builder or llm-gateway
_ = activity?.SetTag("gen_ai.agent.id", streamTransformer.AgentId); // docs-agent or docs_assistant
Expand Down
4 changes: 2 additions & 2 deletions src/api/Elastic.Documentation.Api.Infrastructure/Adapters/AskAi/StreamTransformerBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ private async Task ProcessPipeAsync(PipeReader reader, PipeWriter writer, string
/// <returns>Stream processing result with metrics and captured output</returns>
protected virtual async Task ProcessStreamAsync(PipeReader reader, PipeWriter writer, string? conversationId, Activity? parentActivity, CancellationToken cancellationToken)
{
using var activity = StreamTransformerActivitySource.StartActivity(nameof(ProcessStreamAsync));
using var activity = StreamTransformerActivitySource.StartActivity("process ask_ai stream", ActivityKind.Internal);

if (parentActivity?.Id != null)
_ = activity?.SetParentId(parentActivity.Id);
Expand Down Expand Up @@ -158,7 +158,7 @@ protected virtual async Task ProcessStreamAsync(PipeReader reader, PipeWriter wr
}

var askAiEventType = transformedEvent.GetType().Name;
using var parseActivity = StreamTransformerActivitySource.StartActivity($"AskAI Event {askAiEventType}");
using var parseActivity = StreamTransformerActivitySource.StartActivity($"parse ask_ai event {askAiEventType}");

// Set event type tag on parse_event activity
_ = parseActivity?.SetTag("ask_ai.event.type", askAiEventType);
Expand Down
Loading