Fix AssemblyConfigurationMatchTests for versioned branch logic #2228
+25
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `AssemblyConfiguration.Match()` method now has two code paths for handling version branches: 1. **When `current` is a versioned branch** (e.g., `8.15`): - Build if branch >= current - Build if branch equals the previous minor of current (e.g., `8.14` when current is `8.15`) 2. **When `current` is NOT a versioned branch** (e.g., `main`): - Build if branch >= anchored product version - Do NOT build for previous minor versions - **`VersionBranchSpeculativeBuildBasedOnProductVersion`**: Changed expectation for branch `8.14` with product version `8.15` from `true` to `false`, since `current` is `"main"` and previous minor logic should not apply. - **`VersionBranchSpeculativeBuildWhenMatchesPreviousMinorVersion`**: Changed tests to use versioned `current` branches (e.g., `current: "9.2"`) instead of `current: "main"`, since this test specifically validates previous minor version logic. - **`VersionBranchPreviousMinorCalculationHandlesEdgeCases`**: Changed to use versioned `current` branches (e.g., `current: "8.1"`) to properly test edge cases in previous minor calculation. ### Test Results All 41 tests in `AssemblyConfigurationMatchTests` now pass ✓
cotti
approved these changes
Nov 17, 2025
reakaleek
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AssemblyConfiguration.Match()method now has two code paths for handling version branches:When
currentis a versioned branch (e.g.,8.15):8.14when current is8.15)When
currentis NOT a versioned branch (e.g.,main):VersionBranchSpeculativeBuildBasedOnProductVersion: Changed expectation for branch8.14with product version8.15fromtruetofalse, sincecurrentis"main"and previous minor logic should not apply.VersionBranchSpeculativeBuildWhenMatchesPreviousMinorVersion: Changed tests to use versionedcurrentbranches (e.g.,current: "9.2") instead ofcurrent: "main", since this test specifically validates previous minor version logic.VersionBranchPreviousMinorCalculationHandlesEdgeCases: Changed to use versionedcurrentbranches (e.g.,current: "8.1") to properly test edge cases in previous minor calculation.Test Results
All 41 tests in
AssemblyConfigurationMatchTestsnow pass ✓