Fix/synonym tweaks #2229
Merged
Fix/synonym tweaks #2229
+31
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reakaleek
requested changes
Nov 17, 2025
Mpdreamz
reviewed
Nov 18, 2025
|
|
||
| var lexicalSearchRetriever = | ||
| ((Query)new PrefixQuery(Infer.Field<DocumentDto>(f => f.Title.Suffix("keyword")), searchQuery) { Boost = 10.0f, CaseInsensitive = true } | ||
| || new MatchPhrasePrefixQuery(Infer.Field<DocumentDto>(f => f.Title), searchQuery) { Boost = 9.0f } |
Member
There was a problem hiding this comment.
This is for a follow up but jotting thoughts down here, we probably do not want to have all these prefix queries score so high.
I think we should set up an explicit completion fields:
For general purpose: https://www.elastic.co/docs/reference/elasticsearch/mapping-reference/search-as-you-type
And explicit .prefix multifields on title and maybe headers using (edge)NGram tokenizer (or use the one provided by the search_as_you_type field).
Mpdreamz
approved these changes
Nov 18, 2025
reakaleek
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2159
This PR adjusts the following parameters for lexical searches:
abstractandstripped_bodynow use thesynonyms_analyzer;MatchPhrasePrefixQueryfor synonym-compatible title searches was added to the lexical retriever, at a high priority - but lower than direct matches;synonyms.ymlintact;abstract,stripped_bodyandheadingsall have explicit AND/OR variants, with the AND versions having a higher boost