Skip to content

Conversation

@Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Nov 18, 2025

Relates to: #1995

  1. Fixes previous/next being broken on the boundaries of documentationsets (Incorrect previous/next links #2227)

  2. Also fixes a rendering glitch for the index of DocumentationSets in assembler builds see e.g

https://www.elastic.co/docs/reference/ecs:
image

vs its children which do render correctly when navigated to directly:
https://www.elastic.co/docs/reference/ecs/ecs-using-ecs

  1. Ensure root items such as https://www.elastic.co/docs/versions render an empty navigation vs rendering the whole thing.

  • Ensure SiteNavigation implements INavigationTraverable
  • Ensure we get the current navigation in renderlayout from INavigationTraversable not DocumentationSet.
  • remove NavigationIndexedByCrossLink
  • SiteNavigation and DocumentationSet share assignments for INavigationTraversable

@Mpdreamz Mpdreamz requested a review from a team as a code owner November 18, 2025 13:10
@Mpdreamz Mpdreamz requested a review from cotti November 18, 2025 13:10
@Mpdreamz Mpdreamz added the fix label Nov 18, 2025
@Mpdreamz Mpdreamz self-assigned this Nov 18, 2025
@Mpdreamz Mpdreamz added the fix label Nov 18, 2025
@Mpdreamz Mpdreamz changed the title fix/positional navigation site navigation Fix Previous/Next and related navigation glitches after refactor Nov 18, 2025
Copy link
Contributor

@cotti cotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@cotti
Copy link
Contributor

cotti commented Nov 18, 2025

Check for the issue mentioned @ #2227 :

image

…tead of `GetNavigationItem` or `GetCurrent`.
@Mpdreamz Mpdreamz enabled auto-merge (squash) November 18, 2025 14:28
@Mpdreamz Mpdreamz merged commit 55437f8 into main Nov 18, 2025
24 checks passed
@Mpdreamz Mpdreamz deleted the fix/positional-navigation-site-navigation branch November 18, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants