Add AskAI message feedback endpoint #2297

reakaleek · 2025-12-01T10:52:17Z

Changes

Add new AskAiMessageFeedbackUsecase
Do optimistic UI click handling on thumbsUp/thumbsDown icons.
Feedback is stored in the elasticsearch ask-ai-message-feedback-{env} index

Follow-ups

Verify rate limiting on the infra side.

src/api/Elastic.Documentation.Api.Core/AskAi/AskAiMessageFeedbackUsecase.cs

....Documentation.Api.Infrastructure/Adapters/AskAi/ElasticsearchAskAiMessageFeedbackGateway.cs

src/api/Elastic.Documentation.Api.Core/AskAi/AskAiMessageFeedbackUsecase.cs

src/api/Elastic.Documentation.Api.Core/AskAi/AskAiUsecase.cs

src/api/Elastic.Documentation.Api.Infrastructure/Adapters/AskAi/AgentBuilderAskAiGateway.cs

....Documentation.Api.Infrastructure/Adapters/AskAi/ElasticsearchAskAiMessageFeedbackGateway.cs

src/api/Elastic.Documentation.Api.Infrastructure/Adapters/Search/ElasticsearchGateway.cs

src/api/Elastic.Documentation.Api.Core/LogSanitizer.cs

src/api/Elastic.Documentation.Api.Core/AskAi/AskAiUsecase.cs

src/api/Elastic.Documentation.Api.Core/LogSanitizer.cs

....Documentation.Api.Infrastructure/Adapters/AskAi/ElasticsearchAskAiMessageFeedbackGateway.cs

… IDisposable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

....Documentation.Api.Infrastructure/Adapters/AskAi/ElasticsearchAskAiMessageFeedbackGateway.cs

src/api/Elastic.Documentation.Api.Infrastructure/Adapters/AskAi/AgentBuilderAskAiGateway.cs

…m user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

src/api/Elastic.Documentation.Api.Core/LogSanitizer.cs

…m user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

src/api/Elastic.Documentation.Api.Infrastructure/Adapters/Search/ElasticsearchGateway.cs

…m user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

src/api/Elastic.Documentation.Api.Infrastructure/Adapters/Search/ElasticsearchGateway.cs

…m user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

src/api/Elastic.Documentation.Api.Core/LogSanitizer.cs

src/api/Elastic.Documentation.Api.Core/AskAi/AskAiUsecase.cs

src/api/Elastic.Documentation.Api.Infrastructure/Adapters/AskAi/AgentBuilderAskAiGateway.cs

…m user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Add AskAI message feedback endpoint

ba8a7ef

reakaleek requested a review from a team as a code owner December 1, 2025 10:52

reakaleek requested a review from Mpdreamz December 1, 2025 10:52

github-advanced-security bot found potential problems Dec 1, 2025

View reviewed changes

github-code-quality bot found potential problems Dec 1, 2025

View reviewed changes

....Documentation.Api.Infrastructure/Adapters/AskAi/ElasticsearchAskAiMessageFeedbackGateway.cs Fixed Show fixed Hide fixed

....Documentation.Api.Infrastructure/Adapters/AskAi/ElasticsearchAskAiMessageFeedbackGateway.cs Fixed Show fixed Hide fixed

Adjust otel naming

4ce3f48

reakaleek marked this pull request as draft December 1, 2025 11:46

Add UI onclick handler and other adjustments

1e52f45

github-advanced-security bot found potential problems Dec 1, 2025

View reviewed changes

....Documentation.Api.Infrastructure/Adapters/AskAi/ElasticsearchAskAiMessageFeedbackGateway.cs Fixed Show fixed Hide fixed

....Documentation.Api.Infrastructure/Adapters/AskAi/ElasticsearchAskAiMessageFeedbackGateway.cs Fixed Show fixed Hide fixed

Add log sanitization

264ac88

reakaleek added the feature label Dec 1, 2025

github-code-quality bot found potential problems Dec 1, 2025

View reviewed changes

....Documentation.Api.Infrastructure/Adapters/AskAi/ElasticsearchAskAiMessageFeedbackGateway.cs Fixed Show fixed Hide fixed

....Documentation.Api.Infrastructure/Adapters/AskAi/ElasticsearchAskAiMessageFeedbackGateway.cs Fixed Show fixed Hide fixed

Use spans and create tests

2d08faa

github-advanced-security bot found potential problems Dec 1, 2025

View reviewed changes

github-code-quality bot found potential problems Dec 1, 2025

View reviewed changes

src/api/Elastic.Documentation.Api.Core/LogSanitizer.cs Fixed Show fixed Hide fixed

Remove all control characters as suggested by CodeQL

25eb256

github-code-quality bot found potential problems Dec 1, 2025

View reviewed changes

src/api/Elastic.Documentation.Api.Core/LogSanitizer.cs Fixed Show fixed Hide fixed

reakaleek added 6 commits December 1, 2025 15:05

Validate input

7926de7

Refactor

4df1e5c

Persist reaction selection

d0883cf

Add debounce if user quickly changes selection

3dadebf

Fix other CodeQL errors regarind log sanitization

b48be34

Fix formatting

c2b7c3c

github-advanced-security bot found potential problems Dec 1, 2025

View reviewed changes

src/api/Elastic.Documentation.Api.Core/AskAi/AskAiUsecase.cs Fixed Show fixed Hide fixed

github-code-quality bot found potential problems Dec 1, 2025

View reviewed changes

src/api/Elastic.Documentation.Api.Core/LogSanitizer.cs Fixed Show fixed Hide fixed

reakaleek added 3 commits December 1, 2025 16:20

Fix test

79e4117

Dispose correctly

5de5770

Change scope of services

a112b98

github-code-quality bot found potential problems Dec 1, 2025

View reviewed changes

....Documentation.Api.Infrastructure/Adapters/AskAi/ElasticsearchAskAiMessageFeedbackGateway.cs Fixed Show fixed Hide fixed

....Documentation.Api.Infrastructure/Adapters/AskAi/ElasticsearchAskAiMessageFeedbackGateway.cs Fixed Show fixed Hide fixed

Potential fix for pull request finding 'Missing Dispose call on local…

6eea0cb

… IDisposable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>

github-code-quality bot found potential problems Dec 1, 2025

View reviewed changes

....Documentation.Api.Infrastructure/Adapters/AskAi/ElasticsearchAskAiMessageFeedbackGateway.cs Fixed Show fixed Hide fixed

reakaleek added 2 commits December 1, 2025 21:21

Format

5f6a852

Fix logging format for conversation_id in AgentBuilder

07ff6e6

github-code-quality bot found potential problems Dec 1, 2025

View reviewed changes

....Documentation.Api.Infrastructure/Adapters/AskAi/ElasticsearchAskAiMessageFeedbackGateway.cs Dismissed Show dismissed Hide dismissed

github-advanced-security bot found potential problems Dec 1, 2025

View reviewed changes

src/api/Elastic.Documentation.Api.Infrastructure/Adapters/AskAi/AgentBuilderAskAiGateway.cs Fixed Show fixed Hide fixed

reakaleek and others added 2 commits December 1, 2025 22:17

Fix tests

01cd487

Potential fix for code scanning alert no. 38: Log entries created fro…

ce47e59

…m user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

github-code-quality bot found potential problems Dec 1, 2025

View reviewed changes

src/api/Elastic.Documentation.Api.Core/LogSanitizer.cs Fixed Show fixed Hide fixed

Re-add fast path for common cases to avoid string allocation

e562c5c

github-code-quality bot found potential problems Dec 1, 2025

View reviewed changes

src/api/Elastic.Documentation.Api.Core/LogSanitizer.cs Fixed Show fixed Hide fixed

Potential fix for code scanning alert no. 35: Log entries created fro…

d313731

…m user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

github-advanced-security bot found potential problems Dec 1, 2025

View reviewed changes

Potential fix for code scanning alert no. 39: Log entries created fro…

ce6d0ea

…m user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

github-advanced-security bot found potential problems Dec 1, 2025

View reviewed changes

reakaleek and others added 2 commits December 1, 2025 23:57

Potential fix for code scanning alert no. 43: Log entries created fro…

7dca09e

…m user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Also remove newlines

65ad494

github-code-quality bot found potential problems Dec 1, 2025

View reviewed changes

src/api/Elastic.Documentation.Api.Core/LogSanitizer.cs Fixed Show fixed Hide fixed

reakaleek added 2 commits December 2, 2025 00:29

Remove user input from logs

f622191

Remove this troublesome log for now

717d3d2

reakaleek marked this pull request as ready for review December 2, 2025 00:04

reakaleek self-assigned this Dec 2, 2025

Mpdreamz approved these changes Dec 2, 2025

View reviewed changes

reakaleek added 3 commits December 4, 2025 15:32

Remove logsanitizer

9383978

Fix merge conflicts

4e529b8

Fix spacing and colors

4f5e875

github-advanced-security bot found potential problems Dec 5, 2025

View reviewed changes

src/api/Elastic.Documentation.Api.Core/AskAi/AskAiUsecase.cs Fixed Show fixed Hide fixed

src/api/Elastic.Documentation.Api.Infrastructure/Adapters/AskAi/AgentBuilderAskAiGateway.cs Fixed Show fixed Hide fixed

reakaleek and others added 2 commits December 5, 2025 10:25

Convert ConversationId to Guid

6640f47

Potential fix for code scanning alert no. 47: Log entries created fro…

66ef85c

…m user input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

reakaleek merged commit f717d9b into main Dec 5, 2025
36 of 37 checks passed

reakaleek deleted the feature/ask-ai-message-feedback-endpoint branch December 5, 2025 10:22

Add AskAI message feedback endpoint #2297

Add AskAI message feedback endpoint #2297

Uh oh!

Conversation

reakaleek commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Follow-ups

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

reakaleek commented Dec 1, 2025 •

edited

Loading