Improve search filtering with server-side type aggregations and post_filter #2305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…filter - Implement server-side type filtering using Elasticsearch `post_filter` for accurate aggregation counts - Add terms aggregation on `type` field to return doc/api counts from the server - Refactor search API types: rename `SearchRequest`/`SearchResponse` to `SearchApiRequest`/`SearchApiResponse` - Replace tuple return type in `ISearchGateway` with new `SearchResult` record - Return aggregations nested under `aggregations.type` for future extensibility - Update frontend to fetch filtered results from server instead of client-side filtering - Add `typeFilter` state to search store for consistent filter state management - Split `ElasticsearchIngestChannel` and `ElasticsearchMarkdownExporter` into partial files for better code organization - `ISearchGateway.SearchAsync` now returns `SearchResult` with `TotalHits`, `Results`, and `Aggregations` - Search endpoint accepts `type` query parameter (values: `doc`, `api`) - `post_filter` ensures aggregation counts reflect total matches regardless of active filter - New `SearchAggregations` record wraps type counts for clean JSON structure - Filter selection triggers new API request with `?type=` parameter - Aggregation counts from server displayed in filter buttons - Removed client-side result filtering (server handles it) - Query cache keys include `typeFilter` for proper result caching
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/api/Elastic.Documentation.Api.Infrastructure/Adapters/Search/ElasticsearchGateway.cs
Fixed
Show fixed
Hide fixed
src/api/Elastic.Documentation.Api.Infrastructure/Adapters/Search/ElasticsearchGateway.cs
Fixed
Show fixed
Hide fixed
reakaleek
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
post_filterfor accurate aggregation countstypefield to return doc/api counts from the serverSearchRequest/SearchResponsetoSearchApiRequest/SearchApiResponseISearchGatewaywith newSearchResultrecordaggregations.typefor future extensibilitytypeFilterstate to search store for consistent filter state managementElasticsearchIngestChannelandElasticsearchMarkdownExporterinto partial files for better code organizationTechnical Details
Backend
ISearchGateway.SearchAsyncnow returnsSearchResultwithTotalHits,Results, andAggregationstypequery parameter (values:doc,api)post_filterensures aggregation counts reflect total matches regardless of active filterSearchAggregationsrecord wraps type counts for clean JSON structureFrontend
?type=parametertypeFilterfor proper result cachingcursorful-video-1764847637167.mp4