Skip to content

fix double log message #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix double log message #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Elastic.Markdown/DocumentationGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,11 @@ private bool CompilationNotNeeded(GenerationState? generationState, out HashSet<
outputSeenChanges = generationState?.LastSeenChanges ?? DateTimeOffset.MinValue;
if (generationState == null)
return false;
if (Context.Force)
{
_logger.LogInformation($"Full compilation: --force was specified");
return false;
}

if (Context.Git != generationState.Git)
{
Expand All @@ -144,7 +149,6 @@ private bool CompilationNotNeeded(GenerationState? generationState, out HashSet<
_logger.LogInformation($"Incremental compilation. since: {generationState.LastSeenChanges}");
else if (DocumentationSet.LastWrite <= outputSeenChanges)
{
_logger.LogInformation($"No compilation: no changes since last observed: {generationState.LastSeenChanges}");
_logger.LogInformation($"No compilation: no changes since last observed: {generationState.LastSeenChanges} "
+ "Pass --force to force a full regeneration");
return true;
Expand All @@ -157,6 +161,7 @@ private async Task GenerateLinkReference(Cancel ctx)
{
var file = DocumentationSet.LinkReferenceFile;
var state = LinkReference.Create(DocumentationSet);

var bytes = JsonSerializer.SerializeToUtf8Bytes(state, SourceGenerationContext.Default.LinkReference);
await DocumentationSet.OutputPath.FileSystem.File.WriteAllBytesAsync(file.FullName, bytes, ctx);
}
Expand Down
Loading