Skip to content

[9.2] Device Control #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 20, 2025
Merged

[9.2] Device Control #3178

merged 12 commits into from
Oct 20, 2025

Conversation

benironside
Copy link
Contributor

Fixes elastic/docs-content-internal/issues/356 by adding documentation for the device control feature.

@benironside benironside self-assigned this Sep 25, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2025 •
edited
Loading

🔍 Preview links for changed docs

@benironside benironside marked this pull request as ready for review October 1, 2025 18:40
@benironside benironside requested review from a team as code owners October 1, 2025 18:41
@benironside
Copy link
Contributor Author

Roxana gave an initial LGTM via Slack. Ready for review.

natasha-moore-elastic
natasha-moore-elastic reviewed Oct 2, 2025
View reviewed changes
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for picking this up, @benironside!
Looking at the figma mocks, it seems that this feature introduces a new protection type on the Defend integration policy (called USB Device protection in the mocks). If so, we’d need to doc this on the Configure an integration policy for Elastic Defend page, where all the other protection types are doc’ed. In fact, it feels like the content from the first two paragraphs here (Device control and Configure Device Control for your hosts using Elastic Defend) should be on the Configure an integration policy for Elastic Defend page, and the new page should focus on trusted devices, similar to the Trusted applications page.

natasha-moore-elastic
natasha-moore-elastic reviewed Oct 14, 2025
View reviewed changes
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just needs a few more tweaks to make it consistent with our docs for other endpoint artifacts. Thanks!

benironside and others added 3 commits October 14, 2025 11:22
@benironside @natasha-moore-elastic
Apply suggestions from code review
6ce36d2 
Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
@benironside
incorporates Nat's review
62d05be
@benironside
Merge branch 'main' into 356-internal
99a4c6c
natasha-moore-elastic
natasha-moore-elastic approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of copy-paste fixes, after that good to go! 🚀

@benironside @natasha-moore-elastic
Apply suggestions from code review
59ea0b4 
Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
@benironside benironside enabled auto-merge (squash) October 20, 2025 20:12
@benironside benironside merged commit 64b9ce4 into main Oct 20, 2025
7 of 8 checks passed
@benironside benironside deleted the 356-internal branch October 20, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natasha-moore-elastic natasha-moore-elastic natasha-moore-elastic approved these changes

Assignees

@benironside benironside

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benironside @natasha-moore-elastic