Skip to content

Conversation

florent-leborgne
Copy link
Contributor

This PR:

  • Adds a section about using tabs in Discover and how to manage these tabs
  • Edits the Save Discover session section to add the notion of tabs being saved as part of the Discover session
  • Adds a note about recommended fields (unrelated to tabs but noticed this on the way)

Closes: #3145

Copy link

github-actions bot commented Oct 10, 2025

🔍 Preview links for changed docs

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a few minor suggestions :)

florent-leborgne and others added 3 commits October 11, 2025 08:06
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good on my end, thanks! Left a few nits and suggestions, but nothing blocking.

- Reorder them: Drag and drop a tab to move it.
- Close them: Hover over a tab and select the {icon}`cross` icon.
- Close several tabs at once: When you hover over a tab and select the {icon}`boxes_vertical` **Actions** icon, options let you **Close other tabs** to keep only the active tab open or **Close tabs to the right** to only keep your first tabs and discard any subsequent tabs.
- Reopen recently closed tabs: If you close a tab by mistake, you can retrieve it by selecting the {icon}`boxes_vertical` **Tabs bar menu** icon located at the end of the tab bar.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading this, I feel like we should rename the "Tabs bar menu" button in the UI and come back to update these docs later 😅 The plural "tabs" flows a bit oddly and I see you refer to it as "tab bar" in this sentence too. Any suggestions, maybe just "Tabs menu" would work?

Copy link
Contributor Author

@florent-leborgne florent-leborgne Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to call this something with verb, but I find this menu a bit odd and even Manage tabs isn't fully accurate because you can do some actions (access/restore tabs and clear some in batch), but not individual actions :D
Maybe "Tabs menu" would do yes as you suggested. Maybe it's more like a "Tab history" for the current session

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's a bit of an odd one and tricky to name. Not 100% sure what to call it yet, but I'm sure we can land on something reasonable. I opened an issue for it here so we don't forget at least: elastic/kibana#239420.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that might be missing is that you can clear all tabs and start a new Discover session using the "+" button in the application menu bar. This gets you out of the currently open Discover session if there is one and starts a fresh unsaved session, which manually closing open tabs doesn't. Maybe this is clear from other parts of the docs though, I didn't check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right I didn't think of this and should call this out. I'll add this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually a bit scary that you can flush your current session without a warning if it has unsaved changes. And if it has never been saved in the 1st place, you also don't get the "unsaved changes" warning. That's cold! 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed 😬 There are definitely still some rough edges around tab management to work through in post-MVP phases. We at least have the recently closed menu to help recover accidentally lost tabs for now, but still worth refining some of these scenarios.

florent-leborgne and others added 7 commits October 16, 2025 11:46
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
@florent-leborgne florent-leborgne enabled auto-merge (squash) October 17, 2025 08:05
@florent-leborgne florent-leborgne merged commit 3f5f954 into elastic:main Oct 17, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Discover] Discover tabs

3 participants