Update ECK 3.2 upgrade documentation (#2361) #3677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhr323
changed the title
shainaraskas
approved these changes
Oct 27, 2025
Collaborator
|
I need to quickly preview this locally ... not sure if it will like the double annotation |
|
|
||
| ``` | ||
| 1.6, 1.9, 2.0, 2.1, 2.2, 2.4, 2.5, 2.6, 2.7, 2.8, 2.14, 3.1 <1> | ||
| 1.6, 1.9, 2.0, 2.1, 2.2, 2.4, 2.5, 2.6, 2.7, 2.8, 2.14, 3.1 <1>, 3.2 <1> |
Collaborator
There was a problem hiding this comment.
sorry for the approval and then the un-approval. I think you might want to move to a footnote instead because this is how this renders
so this becomes
1.6, 1.9, 2.0, 2.1, 2.2, 2.4, 2.5, 2.6, 2.7, 2.8, 2.14, 3.1^1^, 3.2^1^
^1^ Footnote text
kilfoyle
reviewed
Oct 27, 2025
|
|
||
| ``` | ||
| 1.6, 1.9, 2.0, 2.1, 2.2, 2.4, 2.5, 2.6, 2.7, 2.8, 2.14, 3.1 <1> | ||
| 1.6, 1.9, 2.0, 2.1, 2.2, 2.4, 2.5, 2.6, 2.7, 2.8, 2.14, 3.1 <1>, 3.2 <1> |
Contributor
There was a problem hiding this comment.
Suggested change
| 1.6, 1.9, 2.0, 2.1, 2.2, 2.4, 2.5, 2.6, 2.7, 2.8, 2.14, 3.1 <1>, 3.2 <1> | |
| 1.6, 1.9, 2.0, 2.1, 2.2, 2.4, 2.5, 2.6, 2.7, 2.8, 2.14, 3.1, 3.2 <1> |
Having the two <#> tags puts both at the end of the line:
Contributor
There was a problem hiding this comment.
Ah, nevermind. @shainaraskas's solution is better. :-)
kilfoyle
approved these changes
Oct 27, 2025
Contributor
kilfoyle
left a comment
kilfoyle
left a comment
There was a problem hiding this comment.
LGTM! 🚀
Just a small suggestion for the code annotation.
|
|
||
| Upgrading the operator results in a one-time update to existing managed resources in the cluster. This potentially triggers a rolling restart of pods by Kubernetes to apply those changes. The following list contains the ECK operator versions that would cause a rolling restart after they have been installed. | ||
|
|
||
| ``` |
Collaborator
There was a problem hiding this comment.
code fences will make the footnotes not render as expected
Suggested change
| ``` |
| ``` | ||
| 1.6, 1.9, 2.0, 2.1, 2.2, 2.4, 2.5, 2.6, 2.7, 2.8, 2.14, 3.1 <1> | ||
| 1.6, 1.9, 2.0, 2.1, 2.2, 2.4, 2.5, 2.6, 2.7, 2.8, 2.14, 3.1^1^, 3.2^1^ | ||
| ``` |
Collaborator
There was a problem hiding this comment.
Suggested change
| ``` |
rhr323
force-pushed
the
update-eck-upgrade-docs
branch
from
2413e2e to
760bf1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation to say upgrading to ECK 3.2 will cause restarts when stack monitoring is used (same as for ECK 3.1).