[D&M] WIP cluster comms #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leemthompo
changed the title
eedugon
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
I think this is a great first iteration, placing a lot of content into the right places.
I'd like to perform a deeper review and maybe reorganize some parts in a follow-up PR after checking some areas with @shainaraskas too.
There was a problem hiding this comment.
I think this is ok for the moment, but probably it would look better and less complex to create sub-pages for different deployment types if they are too complex, like ECK.
I'd like to try that in a future PR and reorganize the content a bit.
There was a problem hiding this comment.
I agree 100% I wanted to get something in front of your eyes because I was thrashing around in here, the ECK parts just started growing 😆
Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
eedugon
force-pushed
the
leemthompo/dm-security-cluster-comms
branch
from
5d227a1 to
ef0dfdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👁️🐽 👁️ https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/765/deploy-manage/security/secure-cluster-communications
TODO
Polish secure-your-cluster-deployment.md
fix https://github.com/elastic/kibana/blob/main/docs/reference/configuration-reference/general-settings.md to stop the anchor warning in this PR