Skip to content

Adds applies_to tags to Troubleshoot > Ingest tools #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

Adds applies_to tags to Troubleshoot > Ingest tools #875

merged 2 commits into from
Mar 25, 2025

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Mar 21, 2025 •
edited
Loading

Adds applies_to tags to the Troubleshoot > Ingest tools section.

Preview: Ingest tools

@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review March 21, 2025 12:42
marciw
marciw approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM but I defer to the experts who are also reviewing 😁

karenzone
karenzone approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping that we could avoid versioning Ingest tools because they are vehicles for getting data into Elasticsearch and not features. Troubleshooting makes for an interesting overlap, and I think it makes sense.

@natasha-moore-elastic natasha-moore-elastic enabled auto-merge (squash) March 25, 2025 08:48
@natasha-moore-elastic natasha-moore-elastic merged commit fcad090 into main Mar 25, 2025
3 of 4 checks passed
@natasha-moore-elastic natasha-moore-elastic deleted the ts-applies-ingest branch March 25, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marciw marciw marciw approved these changes

@karenzone karenzone karenzone approved these changes

@kilfoyle kilfoyle Awaiting requested review from kilfoyle

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@natasha-moore-elastic @marciw @karenzone