Skip to content

Conversation

eedugon
Copy link
Contributor

@eedugon eedugon commented Mar 26, 2025

This PR updates the certificates and security-setup information. Part of https://github.com/elastic/docs-projects/issues/346#issue-2788754652

  • TOC and navigation has been changed and simplified
  • Security setup methods for self-managed deployments have been organized in self-setup.md file.
  • Landing pages have been updated.

Main pages to review:

Still pending (not sure if doing that in this PR or in another one).

  • Long tutorial: I have left it under self-managed security setup, but not sure if it's worthy at all, it's just a different tutorial covering all components. Update: doc moved back to raw content.
  • Configure security in kibana (that doc has a lot of duplicated info): That's a work in progress item, I think we could remove it and just place the only needed parts somewhere else, feel free to share your thoughts. I've left the file with some comments. Update: doc updated and included in the set.

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments, mostly regarding the security features by deployment type stuff

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/941/deploy-manage/security/enabling-cipher-suites-for-stronger-encryption and https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/941/deploy-manage/security/supported-ssltls-versions-by-jdk-version is missing applies info.

on the cipher suites page, it would be good to specify whether the cipher suites are enabled by default in other deployment types as well. there is also a floating backtick on the page that needs to be removed.

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK comments are done now :)

all of them are either me being picky or small accuracy questions that should be easy to knock out. will checkmark this in case you're feeling excited to merge it but you should try to clean up the little style weirdness and make sure every page has applies tags.

eedugon and others added 3 commits April 1, 2025 20:41
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@eedugon eedugon merged commit be08e5b into main Apr 2, 2025
4 checks passed
@eedugon eedugon deleted the security_comms branch April 2, 2025 08:30
@eedugon eedugon mentioned this pull request Apr 2, 2025
florent-leborgne pushed a commit that referenced this pull request Apr 2, 2025
I forgot to apply a commit in
#941
Minor changes
cc: @shainaraskas

---------

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants