Skip to content

Conversation

@russcam
Copy link
Contributor

@russcam russcam commented Feb 18, 2021

This commit updates the configuration for the APM
.NET agent to include the 1.8 branch, and set it as
the current branch.

This commit updates the configuration for the APM
.NET agent to include the 1.8 branch, and set it as
the current branch
@russcam russcam requested a review from bmorelli25 February 18, 2021 01:02
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conf.yaml references the branch in the apm-agent-dotnet repo that we build the docs from. As we build from 1.x, there shouldn't be any updates required to this file on minor releases. Are there docs that you're not seeing live, that you expect to be live?

@bmorelli25 bmorelli25 self-requested a review February 18, 2021 01:34
@bmorelli25
Copy link
Member

bmorelli25 commented Feb 18, 2021

Alright, @russcam just made my day on zoom–The .NET agent is changing their branching strategy to match that of the stack 🎉 . Versioning will still be unique, but mirroring the stack's branching strategy will allow for easier cross-linking of docs, docs/ci-checked releases, and better visibility into documentation/product changes over minor releases. I'll push some changes to this PR tomorrow.

@bmorelli25
Copy link
Member

bmorelli25 commented Feb 18, 2021

87c273c Merges in the 7.12 branch update.

b61c0fc Updates documentation links from Stack versioned books (v6.5-v7.x) to point to the 1.8 version of the .NET reference. This is necessary because 1.x is changing from the current, released version of the documentation to the future, unreleased version. Future minor release will only need to update through the current stack version. For example, if 1.9 released today, a change would only need to be made to stack/7.x.asciidoc, stack/7.12.asciidoc, and stack/7.11.asciidoc.

@bmorelli25 bmorelli25 requested a review from gtback February 18, 2021 20:08
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@bmorelli25
Copy link
Member

Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants