Skip to content

Conversation

gtback
Copy link
Member

@gtback gtback commented Jan 27, 2022

This PR builds on #2333, but @jrodewig and I want to update some more attributes for 7.17 without potentially breaking links that were already fixed in that PR (you're welcome, @bmorelli25 😁 ). If all the tests pass here, we'll merge the changes into #2333, otherwise we'll merge that one first and then follow up with any more links that need to be fixed here.

@gtback gtback marked this pull request as draft January 27, 2022 15:55
@jrodewig
Copy link
Contributor

jrodewig commented Jan 27, 2022

@gtback I finished pushing my changes over and everything is passing. If this LGTY, I'll push my commit(s) over to #2333.

@gtback
Copy link
Member Author

gtback commented Jan 27, 2022

@jrodewig sounds good to me!

@gtback gtback closed this Jan 27, 2022
@gtback gtback deleted the gtback/test-7.17-attributes branch January 28, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants