Note that the full path is required for local doc build #2364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @matschaffer, I'm not sure if this is actually required (it doesn't hurt of course, so I'm fine with this change). I was able to run this command from my local All of the path arguments can be weird and confusing, and I haven't tried with the beats docs. Using the aliases is recommended, both for consistency and to make sure you have all the relevant files that are needed to build a specific book.. |
|
Hrm. Yeah, it seems to work for me without the full path now. Not sure why it didn't the first time. Sorry I didn't copy the error message. |
v1v
added a commit
to v1v/docs
that referenced
this pull request
Feb 3, 2022
…tral-naming * upstream/master: (28 commits) Fixes .net book generation. (elastic#2367) Add main branch to elasticsearch-net repo to docs build. (elastic#2196) Update attributes.asciidoc (elastic#2365) Note that the full path is required for local doc build (elastic#2364) Bump current version to 7.17 (elastic#2333) moves old file back to bottom add new path for kibana links check apm: Neutral naming for apm-agent-java (elastic#2350) Change current to MS-68 (elastic#2355) Remove unnecessary branch mapping for package-spec (elastic#2359) Adds tech preview macro, updates experimental (elastic#2340) [DOCS] Add `plugins-7x` and `plugins-6x` attributes (elastic#2358) apm: Neutral naming for apm-agent-python (elastic#2348) apm: Neutral naming for apm-agent-rum-js (elastic#2354) apm: Neutral naming for apm-agent-dotnet (elastic#2352) apm: Neutral naming for apm-agent-nodejs (elastic#2353) Neutral naming for apm-agent-go (elastic#2351) apm: Neutral naming for apm-agent-php (elastic#2349) Add 7.last attribute for APM Guide (elastic#2356) [apm] main branch for apm-agent-ruby (elastic#2347) ...
v1v
added a commit
to v1v/docs
that referenced
this pull request
Feb 3, 2022
…r-neutral-naming * upstream/master: [DOCS] 8.0.0-rc2 version attributes. (elastic#2345) Rename master to main for Beats project (elastic#2337) Fixes .net book generation. (elastic#2367) Add main branch to elasticsearch-net repo to docs build. (elastic#2196) Update attributes.asciidoc (elastic#2365) update stack ecs pointer adding in new ecs options per the 8.2 sff Note that the full path is required for local doc build (elastic#2364) Bump current version to 7.17 (elastic#2333) moves old file back to bottom add new path for kibana links check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to confirm the issues on elastic/beats#30014 I found this readme, but it wasn't clear that I needed a full path until I started reading through https://github.com/elastic/docs/blob/master/doc_build_aliases.sh
Seemed like we should probably clarify that a full path is expected.